Skip to content

Fix #1633: docs: update docs/architecture/workflows.md npm script table for eval commands#1655

Merged
WilliamBerryiii merged 3 commits into
microsoft:mainfrom
matysanchez:hunter/issue-1633
Jun 6, 2026
Merged

Fix #1633: docs: update docs/architecture/workflows.md npm script table for eval commands#1655
WilliamBerryiii merged 3 commits into
microsoft:mainfrom
matysanchez:hunter/issue-1633

Conversation

@matysanchez

@matysanchez matysanchez commented May 25, 2026

Copy link
Copy Markdown
Contributor

Closes #1633

What

Adds the six new eval:* scripts to the npm script reference table in docs/architecture/workflows.md, and updates the lint:all row to note that eval:lint is now part of the chain.

Why

These scripts were added to package.json in commit 1102901 (feat(evals): add npm eval scripts and shared environments #1626) but were absent from the documentation table.

Tested

Visual review of the rendered table: pipe columns align with the existing header and surrounding rows; diff is purely additive except for the one updated lint:all description.

Agent verification

```
branch: hunter/issue-1633
files-changed: 1
commit: 2a4911c
verification: Visual review of rendered table; pipe columns align with header and surrounding rows; diff shows only 7 additions + 1 deletion in docs/architecture/workflows.md
```

Add rows for `eval:lint`, `eval:run`, `eval:run:skills`,
`eval:run:agents`, `eval:run:scripts`, and `eval:compare`, and note
that `lint:all` now chains `eval:lint`.

Closes microsoft#1633
@matysanchez matysanchez marked this pull request as ready for review May 25, 2026 17:16
@matysanchez matysanchez requested a review from a team as a code owner May 25, 2026 17:16
@matysanchez

Copy link
Copy Markdown
Contributor Author

@WilliamBerryiii — when you have a moment, would you take a look? No rush.

I picked you based on merged 1 docs PR in last 6 months; happy to address feedback or re-route to someone better if you're not the right person.

@matysanchez

Copy link
Copy Markdown
Contributor Author

@katriendg — branch protection requires a second approval here; @WilliamBerryiii already signed off.

Pinging you based on 7 merged PRs in last 6 months (active maintainer). Happy to address feedback if anything stands out, or re-route to someone better if you'd prefer.

@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.62%. Comparing base (c5fcf0b) to head (7d4ac95).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
+ Coverage   80.55%   85.62%   +5.06%     
==========================================
  Files         112       86      -26     
  Lines       18679    12549    -6130     
==========================================
- Hits        15047    10745    -4302     
+ Misses       3632     1804    -1828     
Flag Coverage Δ
pester 84.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bindsi bindsi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review (bindsi batch). Straightforward docs update: adds the eval:* npm script entries and corrects the lint:all description in docs/architecture/workflows.md. Accurately reflects the current package.json script surface. LGTM.

@WilliamBerryiii WilliamBerryiii merged commit a586699 into microsoft:main Jun 6, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update docs/architecture/workflows.md npm script table for eval commands

4 participants